Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 7, 2025


PR-Codex overview

This PR focuses on updating the layout and styling of the Hero component in the page.tsx file, including adjustments to padding and text size for better visual presentation.

Detailed summary

  • Changed padding classes in the section element from py-14 to pt-14 pb-6.
  • Updated the paragraph text size from text-lg to text-base for smaller screens while retaining lg:text-lg for larger screens.
  • Adjusted the margin-bottom of the paragraph from mb-8 to mb-6.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Style
    • Adjusted Hero section vertical spacing to improve layout balance between top and bottom.
    • Refined introductory paragraph spacing and responsive font sizing for clearer readability across screen sizes.

@linear
Copy link

linear bot commented Nov 7, 2025

PRO-73 New image

@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Nov 7, 2025 8:42pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
nebula Skipped Skipped Nov 7, 2025 8:42pm
thirdweb_playground Skipped Skipped Nov 7, 2025 8:42pm
thirdweb-www Skipped Skipped Nov 7, 2025 8:42pm
wallet-ui Skipped Skipped Nov 7, 2025 8:42pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

⚠️ No Changeset found

Latest commit: 282edf7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – nebula November 7, 2025 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 7, 2025 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 7, 2025 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 7, 2025 20:28 Inactive
@MananTank MananTank marked this pull request as ready for review November 7, 2025 20:28
@MananTank MananTank requested review from a team as code owners November 7, 2025 20:28
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Nov 7, 2025
Copy link
Member Author

MananTank commented Nov 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

Walkthrough

Adjusted hero section vertical padding and reduced the intro paragraph's bottom margin; intro paragraph font-size made responsive (small screens text-base, large screens lg:text-lg), with no other structural changes.

Changes

Cohort / File(s) Summary
Hero & intro paragraph
apps/portal/src/app/page.tsx
Hero container padding changed from py-14 to pt-14 pb-6; intro paragraph margin changed from mb-8 to mb-6; font-size made responsive with text-base (small) and lg:text-lg (large) instead of a single text-lg.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Files to check: apps/portal/src/app/page.tsx (verify visual spacing and responsive typography).

Pre-merge checks and finishing touches

❌ Failed checks (5 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions 'Update hero images' but the actual changes only involve styling adjustments (padding and text size) with no image updates present in the changeset. Update the title to accurately reflect the changes made, such as '[PRO-73] Portal: Update hero section styling' or verify if image assets were intended to be included.
Description check ⚠️ Warning The description lacks required sections from the template: no notes for reviewer or testing instructions are provided; only a PR-Codex auto-generated summary is included. Fill in the template sections including 'Notes for the reviewer' and 'How to test' to provide context and testing guidance for reviewers.
Linked Issues check ⚠️ Warning The linked issue PRO-73 requires adding a new image for the documentation hero, but the PR only contains styling changes without any image asset additions. Add the new hero image asset to the PR or clarify if this PR is incomplete and the image should be added in a separate commit.
Out of Scope Changes check ⚠️ Warning The styling changes (padding and text size adjustments) are not explicitly mentioned in the linked issue PRO-73 which focuses on providing a new image. Clarify whether styling changes are part of the scope or if they should be separated into a different PR focused on image assets.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pro-73

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 86e477e and 282edf7.

⛔ Files ignored due to path filters (2)
  • apps/portal/src/app/_images/docs-hero-dark.png is excluded by !**/*.png
  • apps/portal/src/app/_images/docs-hero-light.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • apps/portal/src/app/page.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/portal/src/app/page.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.64%. Comparing base (a87e91b) to head (282edf7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8381   +/-   ##
=======================================
  Coverage   54.64%   54.64%           
=======================================
  Files         919      919           
  Lines       60704    60704           
  Branches     4113     4113           
=======================================
  Hits        33171    33171           
  Misses      27431    27431           
  Partials      102      102           
Flag Coverage Δ
packages 54.64% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 104.88 KB (0%)
@thirdweb-dev/nexus (cjs) 316.6 KB (0%)

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 7, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on making stylistic updates to the `Hero` component in the `page.tsx` file, including adjustments to padding and text size in the layout.

### Detailed summary
- Changed padding in the `section` from `py-14` to `pt-14 pb-6`.
- Modified paragraph class from `text-lg` to `text-base` for smaller text size on smaller screens while keeping `lg:text-lg`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Style**
  * Adjusted Hero section vertical spacing for improved layout balance.
  * Enhanced introductory text with responsive font sizing and refined spacing across different screen sizes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 7, 2025 20:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 7, 2025 20:41 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula November 7, 2025 20:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 7, 2025 20:41 Inactive
@graphite-app graphite-app bot merged commit 282edf7 into main Nov 7, 2025
20 of 23 checks passed
@graphite-app graphite-app bot deleted the pro-73 branch November 7, 2025 20:43
@vercel vercel bot temporarily deployed to Production – wallet-ui November 7, 2025 20:43 Inactive
@vercel vercel bot temporarily deployed to Production – nebula November 7, 2025 20:43 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 7, 2025 20:43 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www November 7, 2025 20:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants